-
Notifications
You must be signed in to change notification settings - Fork 27
Switch from setup.py to pyproject.toml #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@trim21 would you be able to review this one? Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 76.26% 76.27%
=======================================
Files 130 129 -1
Lines 33913 33904 -9
=======================================
- Hits 25865 25860 -5
+ Misses 8048 8044 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks everyone for the reviews! I'll double-check tonight whether the changes in the comments are really needed and will either fix or merge this |
also you might consider a build tool that's not setuptools ;) it lacks some features, I've had cases where it couldn't even publish to pypi cause it lacked the new standard |
Thanks a lot! I'll look into it. Do you have any suggestions for the alternative? |
flit-core |
Note to myself: redis-py uses |
i use it does the job without noise but I'm not an expert in this matter and don't have a strong suggestion |
Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
dc3518a
to
7315ba6
Compare
Signed-off-by: Mikhail Koviazin <[email protected]>
We've decided to continue with hatchling. It seems to be more widely adopted. The commit related to that has been added to this PR. |
Signed-off-by: Mikhail Koviazin <[email protected]>
422fa3f
to
ad021bc
Compare
Signed-off-by: Mikhail Koviazin <[email protected]>
ad021bc
to
6edebae
Compare
Signed-off-by: Mikhail Koviazin <[email protected]>
did |
Hey. Thanks for highlighting this. For some reason I thought since it was a recent addition, it would be unavailable on the older Python versions. I was wrong. I'll add it and will continue on this PR tomorrow. |
Signed-off-by: Mikhail Koviazin <[email protected]>
We'll be using "hatchling version" in order to get the version Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
Added it in follow-up commits. Thanks for the hint! |
Highly inspired by #96 by @ds-cbo (Thanks!)
Pull Request check-list
Description of change
Switch from setup.py to pyproject.toml