Skip to content

Conversation

mkmkme
Copy link
Collaborator

@mkmkme mkmkme commented Oct 7, 2025

Highly inspired by #96 by @ds-cbo (Thanks!)

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

Switch from setup.py to pyproject.toml

@mkmkme
Copy link
Collaborator Author

mkmkme commented Oct 7, 2025

@trim21 would you be able to review this one? Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.27%. Comparing base (9ac253a) to head (337f6f1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   76.26%   76.27%           
=======================================
  Files         130      129    -1     
  Lines       33913    33904    -9     
=======================================
- Hits        25865    25860    -5     
+ Misses       8048     8044    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

bogdanp05
bogdanp05 previously approved these changes Oct 8, 2025
ahmedsobeh
ahmedsobeh previously approved these changes Oct 8, 2025
@mkmkme
Copy link
Collaborator Author

mkmkme commented Oct 8, 2025

Thanks everyone for the reviews! I'll double-check tonight whether the changes in the comments are really needed and will either fix or merge this

@amirreza8002
Copy link
Contributor

also you might consider a build tool that's not setuptools ;)

it lacks some features, I've had cases where it couldn't even publish to pypi cause it lacked the new standard

@mkmkme
Copy link
Collaborator Author

mkmkme commented Oct 8, 2025

also you might consider a build tool that's not setuptools ;)

it lacks some features, I've had cases where it couldn't even publish to pypi cause it lacked the new standard

Thanks a lot! I'll look into it. Do you have any suggestions for the alternative?

@trim21
Copy link
Contributor

trim21 commented Oct 8, 2025

also you might consider a build tool that's not setuptools ;)
it lacks some features, I've had cases where it couldn't even publish to pypi cause it lacked the new standard

Thanks a lot! I'll look into it. Do you have any suggestions for the alternative?

flit-core

@mkmkme
Copy link
Collaborator Author

mkmkme commented Oct 8, 2025

also you might consider a build tool that's not setuptools ;)
it lacks some features, I've had cases where it couldn't even publish to pypi cause it lacked the new standard

Thanks a lot! I'll look into it. Do you have any suggestions for the alternative?

Note to myself: redis-py uses hatchling, might worth looking into it as well.

@amirreza8002
Copy link
Contributor

amirreza8002 commented Oct 8, 2025

i use hatch everywhere

it does the job without noise

but I'm not an expert in this matter and don't have a strong suggestion

Signed-off-by: Mikhail Koviazin <[email protected]>
@mkmkme mkmkme dismissed stale reviews from bogdanp05 and ahmedsobeh via c34b03d October 11, 2025 09:15
@mkmkme
Copy link
Collaborator Author

mkmkme commented Oct 11, 2025

We've decided to continue with hatchling. It seems to be more widely adopted. The commit related to that has been added to this PR.

Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
@amirreza8002
Copy link
Contributor

amirreza8002 commented Oct 13, 2025

did dependency-groups not work here?
i did a test and pip install --group dev works for me if dependency-groups is used in pyproject

@mkmkme
Copy link
Collaborator Author

mkmkme commented Oct 13, 2025

did dependency-groups not work here? i did a test and pip install --group dev works for me if dependency-groups is used in pyproject

Hey.

Thanks for highlighting this. For some reason I thought since it was a recent addition, it would be unavailable on the older Python versions. I was wrong. I'll add it and will continue on this PR tomorrow.

We'll be using "hatchling version" in order to get the version

Signed-off-by: Mikhail Koviazin <[email protected]>
Signed-off-by: Mikhail Koviazin <[email protected]>
@mkmkme
Copy link
Collaborator Author

mkmkme commented Oct 15, 2025

did dependency-groups not work here? i did a test and pip install --group dev works for me if dependency-groups is used in pyproject

Added it in follow-up commits. Thanks for the hint!

@mkmkme mkmkme enabled auto-merge (squash) October 15, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants